refactor: Break down long Python files into modular components #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major enhancements to achieve NPS >80 setup experience: - Add Rich terminal UI with determinate progress bars for predictable UX - Implement express setup by default for common project types (React, Vue, Python, etc.) - Enhance technology detection to 95%+ accuracy with modern framework support - Add aggressive caching system for sub-60-second repeat setups - Create modular UI manager and cache manager components - Update all components to support new fast-track setup flow Key improvements: - Vite, Remix, Astro, SvelteKit, Nuxt 3 detection - Monorepo detection (pnpm, Nx, Lerna, Rush, Yarn workspaces) - Test framework detection (Vitest, Playwright, Testing Library) - Express configurations for 5 common stacks with optimal defaults - Modest success messaging following research-based UX patterns 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Refactored detector.py (638→249 lines) into modular sub-detectors: - Created detectors/ package with specialized detector classes - Split into language, framework, monorepo, and test framework detectors - Main detector.py now orchestrates sub-detectors - Refactored config_manager.py (436→190 lines) into config modules: - Extracted EXPRESS_CONFIGS to config/express_configs.py - Created InteractiveConfigurator in config/interactive.py - Main config_manager.py now orchestrates configuration - Extracted role templates from role_files.py (362→112 lines): - Created templates/roles/ with individual .md files for each role - role_files.py now reads templates from files instead of embedded strings - Extracted workflow templates from workflow_files.py (308→71 lines): - Created templates/workflows/ with individual .yml files - workflow_files.py now reads templates from files All files now under 300 lines as required. Black formatted and flake8 compliant. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fixed test_stack_detection.py to set _project_root before calling methods - Fixed test_workflow_generation.py to set up config with code-reviewer role - Tests now work correctly with the new modular architecture
- Fixed TypeError where glob_exists was called with multiple arguments - Split into two separate calls with OR condition
- Fixed test assertions to match new detected_stack (flat list) structure - Updated tests to use enhanced_stack for framework detection - Enhanced auto_configure to use enhanced_stack for better role detection - All 17 tests now pass successfully
- Updated file paths in SETUP_ENHANCEMENT_PLAN.md to reference .conductor/conductor_setup/ - Updated all module locations in SETUP_TECHNICAL_IMPLEMENTATION.md - No user-facing documentation changes needed as functionality remains the same
- Moved SETUP_ENHANCEMENT_PLAN.md to docs/roadmap/setup-enhancement-plan.md - Moved SETUP_TECHNICAL_IMPLEMENTATION.md to docs/roadmap/setup-technical-implementation.md - Added README.md to roadmap directory documenting implementation status - Keeps root directory clean while preserving valuable future enhancement plans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors all Python files exceeding 300 lines into smaller, more maintainable modules as requested. All files are now properly modularized, black formatted, and flake8 compliant.
Changes
🔧 detector.py (638→249 lines)
detectors/packageLanguageDetector,FrameworkDetector,MonorepoDetector,TestFrameworkDetector📋 config_manager.py (436→190 lines)
EXPRESS_CONFIGSdata toconfig/express_configs.pyInteractiveConfiguratorinconfig/interactive.py📄 role_files.py (362→112 lines)
templates/roles/*.mdfiles🤖 workflow_files.py (308→71 lines)
templates/workflows/*.ymlfiles📚 Documentation & Cleanup
docs/roadmap/directoryTest Results
Benefits
🤖 Generated with Claude Code